-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Remove v1 implementation #179
Conversation
Also removing the |
The acceptance test is there for With tons of unit tests and testable examples, we don't need to maintain acceptance tests any more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
A few issues or questions.
|
Yes, I'll create an issue for improving the doc to direct the users to the examples for push and pull.
That's actually how go module works. The module name for BTW, users can import
That's a good point. I will create an issue to track it. |
Created the following issues for tracking |
Signed-off-by: Lixia (Sylvia) Lei <lixia_lei@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing those two.
Resolves #63
Signed-off-by: Lixia (Sylvia) Lei lixia_lei@outlook.com